Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

💯 add percent examples#116

Merged
cldougl merged 2 commits into
developfrom
percent_ex
Oct 2, 2018
Merged

💯 add percent examples#116
cldougl merged 2 commits into
developfrom
percent_ex

Conversation

@cldougl

@cldougl cldougl commented Oct 1, 2018

Copy link
Copy Markdown
Member

@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-116 October 1, 2018 20:04 Inactive
Comment thread tests/dash/app_sizing.py Outdated
"Region": {"width": '30%'},
},
),
section_title("HTML Table - Column Widths defined by Percents"),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make these section titles unique? That way it's clear that it's two sections. i.e. Multiple Columns with Percent Widths and Single Column with Percent Widths.

Comment thread tests/dash/app_sizing.py
section_title("Dash Table - Padding"),
# ...
section_title("Dash Table - Column Widths by Percent"),
# ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then add the second example here?

@chriddyp chriddyp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great examples, definitely things that dash-table should be able to accommodate.

💃

@cldougl
cldougl merged commit 96df001 into develop Oct 2, 2018
@cldougl
cldougl deleted the percent_ex branch October 2, 2018 20:10
@Marc-Andre-Rivet

Copy link
Copy Markdown
Contributor

@cldougl @chriddyp python-3.6 build job was failing at the time of the merge, this is now breaking the develop build

would reformat /home/circleci/project/tests/dash/app_sizing.py
All done! 💥 💔 💥
1 file would be reformatted, 9 files would be left unchanged.
Exited with code 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants