Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Make id prop of table optional #155

Merged
valentijnnieman merged 11 commits into from
Oct 23, 2018
Merged

Make id prop of table optional #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d9ce50c
genRandomId function for when id isn't set
valentijnnieman Oct 22, 2018
1e953e4
Visual tests for Table without id
valentijnnieman Oct 22, 2018
789e2b1
Remove .only from select_row_test
valentijnnieman Oct 23, 2018
d57785d
Also add test.visual-local to root package.json
valentijnnieman Oct 23, 2018
9116d03
Refactor genRandomId function
valentijnnieman Oct 23, 2018
de16ad2
Refactor Table to set id prop in constructor if it's not set
valentijnnieman Oct 23, 2018
b79a758
Add visual test with 2 tables and css prop set
valentijnnieman Oct 23, 2018
83330ab
Refactor isFrontEnd and isBackEnd functions
valentijnnieman Oct 23, 2018
4f6bfbf
Version bump to rc7
valentijnnieman Oct 23, 2018
b97cc36
Revert Table.js commit
valentijnnieman Oct 23, 2018
46f6482
Refactor Table with getId instead of modifiying props
valentijnnieman Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,4 +390,7 @@ Derived properties allow the component to expose complex state that can be usefu
dataframe_previous -> data_previous
dataframe_timestamp -> data_timestamp
derived_virtual_dataframe -> derived_virtual_data
derived_viewport_datafram -> derived_viewport_data
derived_viewport_datafram -> derived_viewport_data

## RC7 - Optional id prop
- The id prop of the table is now optional. It will generate a random id if it's not set.
4 changes: 2 additions & 2 deletions dash_table/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dash_table/demo.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_table/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"type": {
"name": "string"
},
"required": true,
"required": false,
"description": ""
},
"is_focused": {
Expand Down
3 changes: 2 additions & 1 deletion dash_table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-table",
"version": "3.1.0rc6",
"version": "3.1.0rc7",
"description": "Dash table",
"main": "build/index.js",
"scripts": {
Expand All @@ -26,6 +26,7 @@
"lint": "run-s private::lint.js private::lint.ts",
"test": "run-p --race private::host* private::runtests",
"test.visual": "build-storybook && percy-storybook",
"test.visual-local": "build-storybook",

@Marc-Andre-Rivet Marc-Andre-Rivet Oct 22, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"test.watch": "run-p --race \"build:js-test-watch\" --race private::host* private::opentests"
},
"author": "Chris P <chris@plot.ly",
Expand Down
Loading