issue175 editable column#182
Conversation
| editable: boolean, | ||
| column: IVisibleColumn | ||
| ): boolean => editable && (column.editable === undefined || column.editable); No newline at end of file | ||
| editableColumn: boolean | undefined |
There was a problem hiding this comment.
Removing the dependency on the column structure here -- we just care about the editable props
There was a problem hiding this comment.
This is a bit nitpicky, but perhaps naming it columnIsEditable is better, so that it's more clear that it's a boolean and not some sort of column object?
There was a problem hiding this comment.
Sure. Will update to isEditableTable and isEditableColumn
| * Subscribe to [https://github.com/plotly/dash-table/issues/175](https://github.com/plotly/dash-table/issues/175) | ||
| * for more information. | ||
| * If the column-level `editable` flag is set it overrides | ||
| * the table-level `editable` flag for that column. |
There was a problem hiding this comment.
Updating documentation for table and column editable property
valentijnnieman
left a comment
valentijnnieman
left a comment
There was a problem hiding this comment.
One small suggestion, otherwise looks good to me!
| editable: boolean, | ||
| column: IVisibleColumn | ||
| ): boolean => editable && (column.editable === undefined || column.editable); No newline at end of file | ||
| editableColumn: boolean | undefined |
There was a problem hiding this comment.
This is a bit nitpicky, but perhaps naming it columnIsEditable is better, so that it's more clear that it's a boolean and not some sort of column object?
| isEditable(editable, columns[active_cell[1]]) && | ||
| !isMetaKey(e.keyCode) | ||
| ) { | ||
| // setProps({ is_focused: true }); |
There was a problem hiding this comment.
@valentijnnieman While merging, came across this little nugget of code that does nothing since the navigation work. Removing.
3 participants
This fixes #175
Change isEditable logic so that a cell is editable/not editable when the cell 'isEditable' property is true/false, and use table 'isEditable' prop if undefined.
additional units tests for the editable logic