Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

3.1 issue137 centos setup #184

Merged
Marc-Andre-Rivet merged 3 commits into from
Oct 31, 2018
Merged

3.1 issue137 centos setup #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fe83a8
- setuptools 3rd party requires packages prop to not be unicode
Oct 30, 2018
4ea3e52
bump version
Oct 30, 2018
f3f7eca
Merge remote-tracking branch 'origin/master' into 3.1-issue137-centos…
Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,4 +434,8 @@ Derived properties allow the component to expose complex state that can be usefu

## RC16 - Fix copy/paste behavior when copied rows larger than data

Issue: https://github.com/plotly/dash-table/issues/142
Issue: https://github.com/plotly/dash-table/issues/142

## RC17- Linux install

Issue: https://github.com/plotly/dash-table/issues/137
2 changes: 1 addition & 1 deletion dash_table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-table",
"version": "3.1.0rc16",
"version": "3.1.0-rc17",
"description": "Dash table",
"main": "build/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "dash-table",
"version": "3.1.0rc16",
"version": "3.1.0-rc17",
"description": "Dash table",
"main": "build/index.js",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
with open('package.json') as f:
package = json.load(f)

package_name = package["name"].replace(" ", "_").replace("-", "_")
package_name = str(package["name"].replace(" ", "_").replace("-", "_"))

@Marc-Andre-Rivet Marc-Andre-Rivet Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3rd party library used by setuptools for the packages prop can't handle unicode characters.. casting through str(...) removed the unicode encoding and makes everything work.

@T4rk1n T4rk1n Oct 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured it was something to do with the encoding, thanks for confirming it.


setup(
name=package_name,
Expand All @@ -14,5 +14,5 @@
include_package_data=True,
license=package['license'],
description=package['description'] if 'description' in package else package_name,
install_requires=[]
install_requires=['dash']

@Marc-Andre-Rivet Marc-Andre-Rivet Oct 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen this dependency in other dash-* projects, let me know if there's a reason why it shouldn't be included here..

@T4rk1n T4rk1n Oct 31, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It import dash in the __init__.py if that's like the other repos so it needs it.

)