This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 324 - Fix header misalignment regression with "always visible" scrollbar #325
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| import derivedFragmentStyles from 'dash-table/derived/table/fragmentStyles'; | ||
|
|
||
| function validate(style, width) { | ||
| expect(style.length).to.equal(2); | ||
| expect(style[0]).to.not.equal(undefined); | ||
| expect(style[1]).to.not.equal(undefined); | ||
| expect(style[0].length).to.equal(2); | ||
| expect(style[1].length).to.equal(2); | ||
| expect(style[0][1]).to.not.equal(undefined); | ||
| expect(style[0][1].fragment).to.not.equal(undefined); | ||
| expect(style[0][1].fragment.marginRight).to.equal(width); | ||
| } | ||
|
|
||
| describe('fragment styles', () => { | ||
| const cell = { height: 30 }; | ||
| const headers = []; | ||
| const padding = { before: 0, after: 0 }; | ||
| const scrollbarWidth = 20; | ||
| const uiViewport = { scrollTop: 0, scrollLeft: 0, height: 0, width: 0 }; | ||
| const viewport = { data: [], indices: [] }; | ||
|
|
||
| describe('of "ready" virtualized table', () => { | ||
| it('includes scrollbar width styling', () => { | ||
| const style: any = derivedFragmentStyles( | ||
| true, | ||
| cell, | ||
| headers, | ||
| uiViewport, | ||
| viewport, | ||
| padding, | ||
| scrollbarWidth | ||
| ); | ||
|
|
||
| validate(style, scrollbarWidth); | ||
|
Contributor
Author
There was a problem hiding this comment. Basic unit tests to make sure (not-)virtualized table (not-)ready always returns the correct styling for the header alignment / offset. |
||
| }); | ||
| }); | ||
|
|
||
| describe('of "inprogress" virtualized table', () => { | ||
| it('includes scrollbar width styling', () => { | ||
| const style: any = derivedFragmentStyles( | ||
| true, | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| viewport, | ||
| padding, | ||
| scrollbarWidth | ||
| ); | ||
|
|
||
| validate(style, scrollbarWidth); | ||
| }); | ||
| }); | ||
|
|
||
| describe('of "ready" non-virtualized table', () => { | ||
| it('includes scrollbar width styling', () => { | ||
| const style: any = derivedFragmentStyles( | ||
| false, | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| viewport, | ||
| padding, | ||
| scrollbarWidth | ||
| ); | ||
|
|
||
| validate(style, scrollbarWidth); | ||
| }); | ||
| }); | ||
|
|
||
| describe('of "inprogress" non-virtualized table', () => { | ||
| it('includes scrollbar width styling', () => { | ||
| const style: any = derivedFragmentStyles( | ||
| false, | ||
| undefined, | ||
| undefined, | ||
| undefined, | ||
| viewport, | ||
| padding, | ||
| scrollbarWidth | ||
| ); | ||
|
|
||
| validate(style, scrollbarWidth); | ||
| }); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some annoying tidbits related to Cypress -- it seems the additional tests tipped it over into Heap Overflow land.