Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 365 - Fix tooltip position & display with fixed columns/rows #366

Merged
Marc-Andre-Rivet merged 10 commits into from
Feb 7, 2019
Merged

Issue 365 - Fix tooltip position & display with fixed columns/rows #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f52d906
- Fix tooltip position and display for fixed columns/rows
Feb 7, 2019
4d89518
update package lock
Feb 7, 2019
d5be234
npm@6 lockfile
Feb 7, 2019
336bf7b
- show the tests failing before the fix
Feb 7, 2019
3d6123c
- redo the fix
Feb 7, 2019
067b02e
update test
Feb 7, 2019
dae73fc
Update CHANGELOG.md
Marc-Andre-Rivet Feb 7, 2019
7213d89
Update package-info.json
Marc-Andre-Rivet Feb 7, 2019
bacc0f9
Update package.json
Marc-Andre-Rivet Feb 7, 2019
186c0eb
cut down the tooltip delay and duration
Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Added support for single and double quoted column id with arbitrary name

### Fixed
[#365](https://github.com/plotly/dash-table/issues/365)
- Incorrect tooltip behavior if cell is in a fixed row or column

- Incorrect default value for `column_static_tooltip` changed from [] to {}

## [3.3.0] - 2019-02-01
Expand Down
44,185 changes: 7 additions & 44,178 deletions dash_table/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_table/bundle.js.map
View file
Open in desktop

Large diffs are not rendered by default.

44,872 changes: 7 additions & 44,865 deletions dash_table/demo.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_table/demo.js.map
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions dash_table/package-info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
"@percy-io/percy-storybook": "^2.1.0",
"@storybook/cli": "^4.1.11",
"@storybook/react": "^4.1.11",
"@types/ramda": "^0.25.47",
"@types/react": "^16.7.22",
"@types/react-dom": "^16.0.11",
"@types/ramda": "^0.25.48",

@Marc-Andre-Rivet Marc-Andre-Rivet Feb 7, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These got updated by renovate but not the py packaged version

"@types/react": "^16.8.2",
"@types/react-dom": "^16.8.0",
"@types/react-select": "^1.3.4",
"babel-loader": "^8.0.5",
"core-js": "^2.6.3",
Expand All @@ -67,9 +67,9 @@
"npm": "^6.7.0",
"npm-run-all": "^4.1.5",
"ramda": "^0.26.1",
"react": "16.7.0",
"react": "16.8.1",
"react-docgen": "^3.0.0",
"react-dom": "16.7.0",
"react-dom": "16.8.1",
"react-select": "^1.3.0",
"remarkable": "^1.7.1",
"sheetclip": "^0.3.0",
Expand All @@ -78,8 +78,8 @@
"tslint": "^5.12.1",
"typescript": "^3.3.1",
"wait-on": "^3.2.0",
"webpack": "^4.29.0",
"webpack-cli": "^3.2.1",
"webpack": "^4.29.2",
"webpack-cli": "^3.2.3",
"webpack-dev-server": "^3.1.14",
"webpack-preprocessor": "^0.1.12"
},
Expand Down
18 changes: 15 additions & 3 deletions demo/AppMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { TooltipSyntax } from 'dash-table/tooltips/props';

export enum AppMode {
Default = 'default',
FixedTooltips = 'fixed,tooltips',
FixedVirtualized = 'fixed,virtualized',
ReadOnly = 'readonly',
ColumnsInSpace = 'columnsInSpace',
Expand Down Expand Up @@ -108,9 +109,20 @@ function getSpaceInColumn() {
return state;
}

function getFixedTooltipsState() {
const state = getTooltipsState();

state.tableProps.n_fixed_columns = 3;
state.tableProps.n_fixed_rows = 4;

return state;
}

function getTooltipsState() {
const state = getDefaultState();

state.tableProps.tooltip_delay = 250;
state.tableProps.tooltip_duration = 1000;
state.tableProps.tooltips = {
ccc: [
{ type: TooltipSyntax.Markdown, value: `### Go Proverb\nThe enemy's key point is yours` },
Expand All @@ -122,7 +134,7 @@ function getTooltipsState() {
]
};
state.tableProps.column_static_tooltip = {
ccc: { type: TooltipSyntax.Text, value: `There is death in the hane`, delay: 1000, duration: 5000 },
ccc: { type: TooltipSyntax.Text, value: `There is death in the hane` },
ddd: { type: TooltipSyntax.Markdown, value: `Hane, Cut, Placement` },
rows: `Learn the eyestealing tesuji`
};
Expand All @@ -144,8 +156,6 @@ function getTooltipsState() {
if: {
column_id: 'bbb-readonly'
},
delay: 1000,
duration: 5000,
type: TooltipSyntax.Markdown,
value: `### Go Proverbs\nUrgent points before big points\n![Sensei](https://senseis.xmp.net/images/stone-hello.png)`
}];
Expand Down Expand Up @@ -208,6 +218,8 @@ function getState() {
const mode = Environment.searchParams.get('mode');

switch (mode) {
case AppMode.FixedTooltips:
return getFixedTooltipsState();
case AppMode.FixedVirtualized:
return getFixedVirtualizedState();
case AppMode.ReadOnly:
Expand Down
Loading