Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Issue 703 - Rename async modules #704

Merged
Marc-Andre-Rivet merged 5 commits into from
Feb 27, 2020
Merged

Issue 703 - Rename async modules #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cecb4b3
change `~` for `-`
Feb 26, 2020
2332aa2
3.6.9 server tests
Feb 26, 2020
cb5edf2
update manifest
Feb 26, 2020
a814dca
install table from tarball, not local env
Feb 27, 2020
0ed4296
changelog
Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
jobs:
"server-test":
docker:
- image: circleci/python:3.6-node-browsers
- image: circleci/python:3.6.9-node-browsers
- image: cypress/base:10

steps:
Expand Down Expand Up @@ -40,7 +40,9 @@ jobs:
. venv/bin/activate
npm run private::build:js-test
npm run private::build:py
pip install -e .
python setup.py sdist
cd dist
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

@Marc-Andre-Rivet Marc-Andre-Rivet Feb 27, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the opportunity to install from tarball instead of the local folder -e .. This change helps identify issues when resource paths change and the MANIFEST.in file isn't synced.

@alexcjohnson alexcjohnson Feb 27, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that seems important... Is this an issue in any of our other repos? Perhaps a followup issue to check on this as well?


- run:
name: Run tests
Expand Down Expand Up @@ -225,7 +227,9 @@ jobs:
command: |
. venv/bin/activate
npm run build
pip install -e .
python setup.py sdist
cd dist
find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..

- run:
name: ⚙️ run integration test
Expand Down
6 changes: 5 additions & 1 deletion .config/webpack/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ module.exports = (options = {}) => {
name: true,
cacheGroups: {
async: {

chunks: 'async',
minSize: 0,
name(module, chunks, cacheGroupKey) {
return `${cacheGroupKey}-${chunks[0].name}`;
}
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
- [#704](https://github.com/plotly/dash-table/pull/704) Renamed async modules with hyphen `-` instead of tilde `~`

## [4.6.0] - 2020-01-14
### Added
- [#606](https://github.com/plotly/dash-table/pull/606) Add markdown support for table cells. Cells will be rendered as markdown if the column `presentation` is specified as `markdown`.
Expand Down
4 changes: 2 additions & 2 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include dash_table/bundle.js
include dash_table/bundle.js.map
include dash_table/async~*.js
include dash_table/async~*.js.map
include dash_table/async-*.js
include dash_table/async-*.js.map
include dash_table/metadata.json
include dash_table/package-info.json
include LICENSE
Expand Down
8 changes: 4 additions & 4 deletions dash_table_base/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,20 @@
_js_dist = []

_js_dist.extend([{
'relative_package_path': 'async~{}.js'.format(async_resource),
'relative_package_path': 'async-{}.js'.format(async_resource),
'external_url': (
'https://unpkg.com/dash-table@{}'
'/dash_table/async~{}.js'
'/dash_table/async-{}.js'
).format(__version__, async_resource),
'namespace': package_name,
'async': True
} for async_resource in async_resources])

_js_dist.extend([{
'relative_package_path': 'async~{}.js.map'.format(async_resource),
'relative_package_path': 'async-{}.js.map'.format(async_resource),
'external_url': (
'https://unpkg.com/dash-table@{}'
'/dash_table/async~{}.js.map'
'/dash_table/async-{}.js.map'
).format(__version__, async_resource),
'namespace': package_name,
'dynamic': True
Expand Down