This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 486 - Don't scroll menu into view#732
Merged
Merged
Conversation
added 4 commits
April 8, 2020 15:35
- new test (will fail, to pass after the fix added back)
Marc-Andre-Rivet
marked this pull request as ready for review
April 8, 2020 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #486
Closes #672
It seems that this was probably always broken.
Failing test run prior to fix: https://circleci.com/gh/plotly/dash-table/18036
Passing test run with the fix: https://circleci.com/gh/plotly/dash-table/18044