Schedule Tab UI QA roundup

[nicolaskruchten]

Let's gather up a few problems here for fixup in a smaller number of PRs than 1-1...

[nicolaskruchten]

After creating a query, the "Query name" is still editable...

[nicolaskruchten]

If I log out of Plotly (or boot Falcon without logging in) and then write a nice fancy query and then hit "schedule" and go through the login process as prompted, I lose my query, it disappears from the query box so I can't schedule it.

[nicolaskruchten]

If I boot Falcon and I have some queries scheduled but I'm not logged in, I have no indication that these queries aren't going to successfully run unless I do log in.

Per @n-riesco this isn't the case, I had incorrectly assumed it was based on the logged-in/not-logged-in UI. I'm still not sure what is and isn't possible when "not logged in" and why :)

[mfix22]

If I log out of Plotly (or boot Falcon without logging in) and then write a nice fancy query and then hit "schedule" and go through the login process as prompted, I lose my query, it disappears from the query box so I can't schedule it.

Currently when you log in, the entire app is refreshed which makes it non-trivial to persist the query string.

Perhaps instead we disable the schedule button and warn about query loss in a tooltip?

[nicolaskruchten]

This one isn't strictly related to the scheduling stuff, but will resolve #479 and I can't seem to do it in my dev environment due to build errors: I'd like to bump the react-chart-editor dependency from 0.18 to 0.21 please :)

[briandennis]

@nicolaskruchten was your build error similar to the one on CI? I can't replicate this locally when building...

[nicolaskruchten]

Nope, I'm having issues building the Oracle driver from source.

[nicolaskruchten]

From my POV things are looking good here... It'd be great if we could wrap and merge #500 today and then cut a release tomorrow :)