Skip to content

Improve logging#29

Merged
etpinard merged 3 commits into
masterfrom
logging
Nov 21, 2017
Merged

Improve logging#29
etpinard merged 3 commits into
masterfrom
logging

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

resolves #2

head: info.head,
processingTime: info.processingTime
}
}))

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which looks like:

image

does that look ok @scjody ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we could use a severity field in the after-export section. maybe 'INFO'?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. Have you been able to deploy it to stage and see if it looks OK on Stackdriver?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I just tried doing that via plotbot, but I got:

image

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've fixed Plotbot permissions, but there's no Docker image to deploy.

screen shot 2017-11-16 at 17 14 30

The Docker build needs to succeed before you can deploy.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This may have been an intermittent CircleCI issue so I'm going to retry the build.)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rebuild worked. Now I'm dealing with a different deployment issue.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that worked. The latest version of this branch has been deployed to stage.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it looks OK on Stackdriver?

From a private convo with @scjody :

image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps we could use a severity field in the after-export section. maybe 'INFO'?

done in cbb4e13

@etpinard

Copy link
Copy Markdown
Contributor Author

cc @bpostlethwaite who might be interested in helping out.

if (SHOW_LOGS) {
console.log(`export error ${info.code} - ${info.msg}`)
console.log(JSON.stringify({
severity: 'ERROR',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

console.warn(err)
if (SHOW_LOGS) {
console.log(JSON.stringify({
severity: 'ERROR',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@etpinard

Copy link
Copy Markdown
Contributor Author

@scjody @bpostlethwaite wanna give this another 👁️ ?

@scjody scjody left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@etpinard
etpinard merged commit 75fcf45 into master Nov 21, 2017
@etpinard
etpinard deleted the logging branch November 21, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log output

3 participants