Skip to content

Ignore calculated aesthetics that match specified aesthestics #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpsievert merged 1 commit into from
Jan 7, 2020
Merged

Ignore calculated aesthetics that match specified aesthestics #1650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ignore calculated aesthetics that match specified aesthestics 
After tidyverse/ggplot2@10fa0014, it's possible for calculated aes to exist for all default_aes
  • Loading branch information
@cpsievert
cpsievert committed Nov 7, 2019
commit 27db11e278ce92bef7ec9a4c8be5ee3b3078c9e1
8 changes: 5 additions & 3 deletions R/layers2traces.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ layers2traces <- function(data, prestats_data, layout, p) {
position = ggtype(y, "position")
)

# add on plot-level mappings, if they're inherited
map <- c(y$mapping, if (isTRUE(y$inherit.aes)) p$mapping)

# consider "calculated" aesthetics (e.g., density, count, etc)
calc_aes <- y$stat$default_aes[ggfun("is_calculated_aes")(y$stat$default_aes)]
map <- c(y$mapping, calc_aes)
calc_aes <- calc_aes[!names(calc_aes) %in% names(map)]

# add on plot-level mappings, if they're inherited
if (isTRUE(y$inherit.aes)) map <- c(map, p$mapping)
map <- c(calc_aes, map)

# turn symbol (e.g., ..count..) & call (e.g. calc(count)) mappings into text labels
map <- ggfun("make_labels")(map)
Expand Down