quick fix - allow relayout array elements#1133
Merged
Merged
Conversation
etpinard
suggested changes
Nov 10, 2016
| else { | ||
| // check whether we can short-circuit a full redraw | ||
| // 3d or geo at this point just needs to redraw. | ||
| var pp1 = String(p.parts[1] || ''); |
Contributor
There was a problem hiding this comment.
Can you move this new line above the check whether we can short-circuit comment?
etpinard
approved these changes
Nov 10, 2016
Contributor
|
💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bpostlethwaite @etpinard
@etpinard 's fix https://github.com/plotly/streambed/pull/8378/commits/6a74d87370ef2205cdd4a86eb8c4ab4a1332ecd0 will handle your exact case, but a more general cover for this issue (until we redo this whole mess of code!) is just to make the tests of
p.partsnot fail on integer parts.