Skip to content

Fix broken non-animatable transition fallback#1141

Merged
rreusser merged 1 commit into
masterfrom
fix-animation-fallback
Nov 14, 2016
Merged

Fix broken non-animatable transition fallback#1141
rreusser merged 1 commit into
masterfrom
fix-animation-fallback

Conversation

@rreusser

@rreusser rreusser commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

This PR adds a previously-failing test and corresponding bug-fix for animating bar graphs. Since it was not previously tested, a regression snuck in in the logic that skips non-animatable traces. The updates aren't pretty, but at least now modules that have module.animatable !== true will update.

@rreusser rreusser added status: reviewable bug something broken labels Nov 14, 2016
@etpinard

Copy link
Copy Markdown
Contributor

a regression snuck in in the logic that skips non-animatable traces.

Do you which particular commit / PR produce this regression?

@etpinard etpinard added this to the v1.20.0 milestone Nov 14, 2016
@rreusser

rreusser commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

It was this commit: a0da51d

If the module was not animatable, continue skipped the next and final instruction in the loop. I appended another instruction, so that pattern became invalid. Just a logic error due to untested behavior 😞

@etpinard

Copy link
Copy Markdown
Contributor

@rreusser thanks! 💃

@rreusser
rreusser merged commit 7dd96f0 into master Nov 14, 2016
@etpinard
etpinard deleted the fix-animation-fallback branch November 15, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants