Skip to content

SDF strategy for 'fancy' scattergl traces#1398

Merged
etpinard merged 6 commits into
masterfrom
gl-scatter2d-sdf
Mar 13, 2017
Merged

SDF strategy for 'fancy' scattergl traces#1398
etpinard merged 6 commits into
masterfrom
gl-scatter2d-sdf

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

fixes #566

See details in gl-vis/gl-scatter2d-fancy#5

@dfcreative is the man!

@etpinard etpinard added this to the 1.24.0 milestone Feb 20, 2017
@dy

dy commented Feb 21, 2017

Copy link
Copy Markdown
Contributor

@etpinard looking at baselines I've tuned up rendering a bit in gl-scatter2d-sdf@1.3.1, border size should be more consistent. But still rendering in Ubuntu seems to be a bit off

@etpinard

Copy link
Copy Markdown
Contributor Author

@dfcreative done in 18fae27

@etpinard

Copy link
Copy Markdown
Contributor Author

Waiting on more thorough feedback from #566 authors; dropping from the 1.24.0 milestone.

@etpinard etpinard removed this from the 1.24.0 milestone Feb 27, 2017
@etpinard

etpinard commented Mar 3, 2017

Copy link
Copy Markdown
Contributor Author

I noticed something. Looks like something is up with the zoom box:

Current master:

gifrecord_2017-03-03_173257

Off this branch:

gifrecord_2017-03-03_173416

the shaded area used to be transparent, and now it appears to be opaque. I'll investigate next week.

@dy

dy commented Mar 4, 2017

Copy link
Copy Markdown
Contributor

@etpinard fixed with gl-vis/gl-scatter2d-sdf@6ebe332

@etpinard

etpinard commented Mar 6, 2017

Copy link
Copy Markdown
Contributor Author

@dfcreative thanks for the fix!

The new patch affect the gl2d_17 baseline:

gifrecord_2017-03-06_104329

Can you comment on that?

@dy

dy commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

@etpinard thanks, fixed with gl-vis/gl-scatter2d-sdf@1c9ec60
Not the best solution, but persistent across @gl-vis.
That is because for scatter-sdf we have to use special alpha mode (actually natural one), and across other gl-vis components we use another alpha mode, therefore we have to switch context back and forth between alpha modes.

@etpinard

etpinard commented Mar 6, 2017

Copy link
Copy Markdown
Contributor Author

@dfcreative much better!

gifrecord_2017-03-06_142330

Ok. Well, this PR is ready to be merged once the latest gl-scatter2d-sdf patch is published 🎉

This PR should be part of the next minor release v1.25.0 set for early next week.

@etpinard etpinard added this to the v1.25.0 milestone Mar 6, 2017
@dy

dy commented Mar 6, 2017

Copy link
Copy Markdown
Contributor

@etpinard published!

@etpinard

Copy link
Copy Markdown
Contributor Author

Amazing job @dfcreative ... merging 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scattergl triggers WebGL errors when using arrays of symbol, color, or size

2 participants