Contour restyle zmin zmax

[etpinard]

fixes #1649

So, turns out that restyling zmin and zmax for contour traces has been broken since v1.0.0 and nobody noticed 😑

This PR fixes this by making zmin and zmax redo calcdata as the contour calc does use it. Note that this isn't the case for heatmap traces where zmin and zmax are only used in the plot step.

cc @alexcjohnson

[etpinard]

... slowly migrating to something better than those ugly recalcAttrs lists in restyle and relayout.

[alexcjohnson]

Down the line, this is going to require valObject.dostyle, .doplot, .doCamera etc etc... would we be better off with something like valObject.editType = 'docalc' etc? Which presumably we could use like a flaglist (and validate as such in plotschema_test)?

💯 🍻 for getting this effort going!

[etpinard]

valObject.editType = 'docalc'

Right. I guess that scales better. Thanks 👍

[etpinard]

done in 413e545

[alexcjohnson]

👍
I guess later this can change to something like

if(valObject.editType) {
    valObject.editType.split('+').forEach(function(flag) {
        flags[flag] = true;
    });
}

But don't need to do that now - lets wait until we have validation of editType, perhaps in plotschema_test?

[etpinard]

But don't need to do that now - lets wait until we have validation of editType, perhaps in plotschema_test?

Yep, that's what I was thinking. Referencing #648

[alexcjohnson]

Looks good! 💃