Fix scattergl selection#2267
Closed
dy wants to merge 8 commits into
Closed
Conversation
Collaborator
|
Thanks @dfcreative - is there a test we can add that shows that this fixes the bug? |
Conflicts: package.json
Contributor
Author
|
@alexcjohnson added selection test at 348d4d0 |
| var x = [], y = []; | ||
| for(var i = 0; i < 2e4; i++) { | ||
| x.push(Math.random()); | ||
| y.push(Math.random()); |
Collaborator
There was a problem hiding this comment.
there's probably an infinitesimal chance that this will cause any problems, but I still don't like having random calls in a test suite. If you really want something random-looking, as opposed to some simple formula, consider appropriating something reproducible like we used for box plot jitter
Contributor
Author
There was a problem hiding this comment.
Thank you @alexcjohnson! Fixed in 39be256
Collaborator
|
Beautiful, thanks! 💃 |
Contributor
|
cc @cpsievert |
Contributor
Author
|
Closed by cb2729e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2266