Skip to content

Metatext#3439

Merged
etpinard merged 6 commits into
masterfrom
metatext
Jan 16, 2019
Merged

Metatext#3439
etpinard merged 6 commits into
masterfrom
metatext

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

resolves #3427

cc @plotly/plotly_js and @nicolaskruchten

@etpinard etpinard added this to the 1.44.0 milestone Jan 15, 2019
@alexcjohnson

Copy link
Copy Markdown
Collaborator

Does it need to be text? Should we just call it layout.meta? I'm imagining in the short term templating numbers (potentially with a format spec), and longer term possibly using this as a way to share other settings across multiple traces, axes, etc.

@etpinard

Copy link
Copy Markdown
Contributor Author

Should we just call it layout.meta

I don't have a strong opinion.

@nicolaskruchten

Copy link
Copy Markdown
Contributor

Looks great to me! meta works for me, although there is no requirement today to support anything beyond text, we may as well leave the door open.

@etpinard

Copy link
Copy Markdown
Contributor Author

Looks great to me! meta works for me

done in b03e777

@nicolaskruchten

Copy link
Copy Markdown
Contributor

💃

@nicolaskruchten

Copy link
Copy Markdown
Contributor

Ah hang on, do we need to add anything for metasrc ?

@nicolaskruchten

Copy link
Copy Markdown
Contributor

Just so the plotly.py machinery etc doesn't complain about Chart Studio sliding that in...

@etpinard

Copy link
Copy Markdown
Contributor Author

do we need to add anything for metasrc

That's done automatically here:

if(attr.valType === 'data_array') {
// all 'data_array' attrs have role 'data'
attr.role = 'data';
// all 'data_array' attrs have a corresponding 'src' attr
attrs[attrName + 'src'] = makeSrcAttr(attrName);
}

@nicolaskruchten

Copy link
Copy Markdown
Contributor

ok great :)

@etpinard
etpinard merged commit c44ed53 into master Jan 16, 2019
@etpinard
etpinard deleted the metatext branch January 16, 2019 17:25
@etpinard etpinard mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

layout.metatext

3 participants