Fix bar selection on subplots with rangeslider#3806
Merged
Conversation
... instead of during Bar.plot, so that "main" and "rangePlot"
values don't conflict
Contributor
|
Excellent fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3795
before: https://codepen.io/mbkupfer/pen/JVZJzR
after: https://codepen.io/etpinard/pen/QPJLKR
In brief, stashing "pixel" values in the calcdata is generally a bad idea, as "main" and "rangePlot" data-bounds reference the same
gd.calcdataitems but have in general different x/y axis ranges. In other words, "main" and "rangePlot" have the samecvalues, but differentpvalues.@plotly/plotly_js I'd like to slip this one in tomorrow's
v1.47.4