Fix2950 parcoords cannot select first enum#3915
Merged
Merged
Conversation
Contributor
|
Nice fix and cleanup! 💃 Does this also fix #3794 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2950 and https://github.com/plotly/phoenix-integration/issues/201.
The bug was introduced at this line; whereas
i === 1should have been applied.plotly.js/src/traces/parcoords/axisbrush.js
Line 55 in 4a8dd1c
The logic within low and high functions are also refactored and merged into one function.
@plotly/plotly_js