Conversation
etpinard
reviewed
Jun 18, 2019
| function isHidden(gd) { | ||
| var display = window.getComputedStyle(gd).display; | ||
| return !display || display === 'none'; | ||
| } |
Contributor
There was a problem hiding this comment.
Isn't this the same helpers as in Plots.resize?
Can we make this a Lib function?
etpinard
reviewed
Jun 18, 2019
| if(!gd._responsiveChartHandler) { | ||
| // Keep a reference to the resize handler to purge it down the road | ||
| gd._responsiveChartHandler = function() { Plots.resize(gd); }; | ||
| gd._responsiveChartHandler = function() { if(!isHidden(gd)) Plots.resize(gd).catch(Lib.noop); }; |
Contributor
There was a problem hiding this comment.
Do we really need to .catch here?
Contributor
Author
Contributor
|
Thanks for taking this on @antoinerg ! Pinning this for |
Contributor
|
thanks again for doing this @antoinerg 💃 |
Contributor
|
(let's start merging things for 1.49.0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3866 using approach number 2 from comment #3866 (comment)