Skip to content

do not show prefix and suffix for minor log axes#4064

Merged
archmoj merged 3 commits into
masterfrom
minor-log-axes-no-suffix-prefix
Jul 22, 2019
Merged

do not show prefix and suffix for minor log axes#4064
archmoj merged 3 commits into
masterfrom
minor-log-axes-no-suffix-prefix

Conversation

@archmoj

@archmoj archmoj commented Jul 20, 2019

Copy link
Copy Markdown
Contributor

Hopefully fixes #3250 & friends (i.e. #3689).

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jul 20, 2019
Comment thread src/plots/cartesian/axes.js Outdated
@etpinard

Copy link
Copy Markdown
Contributor

Thanks very much for taking this on @archmoj !

I'm curious, you wrote that this PR fixes #3250 & friends, which friend issues are you referring to exactly?

@archmoj

archmoj commented Jul 22, 2019

Copy link
Copy Markdown
Contributor Author

Thanks very much for taking this on @archmoj !

I'm curious, you wrote that this PR fixes #3250 & friends, which friend issues are you referring to exactly?

@etpinard
This one: #3689.

Comment thread src/plots/cartesian/axes.js
Comment thread test/image/mocks/log-axis_no-minor_suffix-prefix.json
@etpinard

Copy link
Copy Markdown
Contributor

This fix is looking good to me 💃

Nice work @archmoj !

@etpinard etpinard added this to the v1.49.0 milestone Jul 22, 2019
@archmoj
archmoj merged commit 1400437 into master Jul 22, 2019
@archmoj
archmoj deleted the minor-log-axes-no-suffix-prefix branch July 22, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tickprefix/suffix on log axes single-digit labels?

2 participants