Added docs about building Plotly correctly with Angular#4182
Conversation
|
Thanks very much for the PR! I've never used plotly.js with angular, so I'll ping @andrefarzat and @TomDemulierChevret who could maybe helps us review your patch. |
|
I don't have time to test this right now, but it seems pretty alright. The only issue for me is that it should include an example with a partial bundle (and if possible a custom bundle) like the existing documentation. |
|
What is a "partial bundle" and where is the custom bundle? |
|
https://github.com/plotly/plotly.js/blob/master/dist/README.md#partial-bundles You don't want to bundle the whole plotly.js lib in your app if you only use a specific subset of charts. The current version of the doc didn't cover custom bundle, but it had an exemple for partial bundle (in the "src/tsconfig.app.json" part). |
|
I found this PR very helpful when trying to build plotly with Angular. |
alexcjohnson
left a comment
There was a problem hiding this comment.
As long as Angular users have found this helpful, that's good enough for me! 💃
Co-authored-by: alexcjohnson <johnson.alex.c@gmail.com>
Added correct howto to build plotly + angular. Removed old variants since
ng ejectis not possible anymore and not building with webGl is basically useless..