Fix react category order of matching axes#4832
Merged
Merged
Conversation
alexcjohnson
approved these changes
May 14, 2020
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Looks good, and for the short term this is probably the safest solution. But my comment about "maybe we can avoid relinking these axes entirely" was sincere - see #749, it's very likely that we're majorly overdoing this, and we'll continue creating new bugs with this step until we identify the specific reason why some keys need relinking, others need to NOT be relinked, and still others don't care. The end result, I suspect, will be an opt-in relink step rather than the current opt-out.
Contributor
Author
|
What is hapening (I think) is that this block plotly.js/src/plots/cartesian/set_convert.js Lines 877 to 909 in 4d383f2 I added few more tests in c2dc252. & merging... |
This was referenced Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4718 and fixes #4826 | before vs after.
@plotly/plotly_js