Fix bar lengths in milliseconds from base#4900
Merged
Merged
Conversation
alexcjohnson
reviewed
Jun 4, 2020
alexcjohnson
reviewed
Jun 4, 2020
alexcjohnson
reviewed
Jun 5, 2020
|
|
||
| var xEnd = out.style[2]; | ||
| expect(xEnd).not.toBe(1580670000000); | ||
| expect(xEnd).toBe(1580688000000); |
Collaborator
There was a problem hiding this comment.
If you're testing toBe, what do you gain from testing not.toBe? 🤔
Contributor
Author
There was a problem hiding this comment.
Just to ensure no one change the test.
alexcjohnson
approved these changes
Jun 5, 2020
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
Very nice - I like the approach of handling this in set_convert so it can be extended later to other situations more easily 🎉
💃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4558.
demo 1: Gantt chart example
demo 2: before vs after
@plotly/plotly_js