Skip to content

add save and edit icon to modebar#5

Merged
cldougl merged 3 commits into
masterfrom
save_icon_modebar
Nov 16, 2015
Merged

add save and edit icon to modebar#5
cldougl merged 3 commits into
masterfrom
save_icon_modebar

Conversation

@cldougl

@cldougl cldougl commented Nov 16, 2015

Copy link
Copy Markdown
Member
  • add icon to save and edit chart in modebar

@chriddyp

Copy link
Copy Markdown
Member

@cldougl - can you make sure that this works from the ipython environment? (I'm sure that it does)

Comment thread src/plots/plots.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐄 no new line

@etpinard

Copy link
Copy Markdown
Contributor

@cldougl a couple 🐄 then let's merge this in.

- fix extra line
- fix spacing around function
@etpinard

Copy link
Copy Markdown
Contributor

Oh right. I just remember we'll need to change the default config so that the 'Edit chart' isn't there by default.

https://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_config.js#L38 should be false.

cldougl added a commit that referenced this pull request Nov 16, 2015
add save and edit icon to modebar
@cldougl
cldougl merged commit 19886d2 into master Nov 16, 2015
@etpinard
etpinard deleted the save_icon_modebar branch November 16, 2015 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants