Skip to content

decrease tolerance for flaky baselines namely mapbox #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 1 commit into from
Jun 26, 2021
Merged

decrease tolerance for flaky baselines namely mapbox #5773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,17 @@ for(var i = 0; i < allMockList.length; i++) {
height: height
});

var shouldBePixelPerfect = mockName.substr(0, 7) !== 'mapbox_' && [
var isMapbox = mockName.substr(0, 7) === 'mapbox_';
var isOtherFlaky = [
// list flaky mocks other than mapbox:
'gl3d_bunny-hull'
].indexOf(mockName) === -1;
].indexOf(mockName) !== -1;

var shouldBePixelPerfect = !(isMapbox || isOtherFlaky);

var numDiffPixels = pixelmatch(img0.data, img1.data, diff.data, width, height, {
threshold: shouldBePixelPerfect ? 0 : 0.2
threshold: shouldBePixelPerfect ? 0 :
mockName === 'mapbox_geojson-attributes' ? 0.2 : 0.15
});

if(numDiffPixels) {
Expand Down