Skip to content

Simplify makeSchema by returning the results #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 1 commit into from
Jun 26, 2021
Merged

Simplify makeSchema by returning the results #5775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ tasks.push(function(done) {
}, function() {
prependFile(pathToPlotlyDistWithMeta, header, common.throwOnError);

makeSchema(pathToPlotlyDistWithMeta, pathToSchema)();
makeSchema(pathToPlotlyDistWithMeta, pathToSchema);
done();
});
});
Expand Down
12 changes: 5 additions & 7 deletions tasks/util/make_schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ var path = require('path');
var plotlyNode = require('./plotly_node');

module.exports = function makeSchema(plotlyPath, schemaPath) {
return function() {
var Plotly = plotlyNode(plotlyPath);
var Plotly = plotlyNode(plotlyPath);

var plotSchema = Plotly.PlotSchema.get();
var plotSchemaStr = JSON.stringify(plotSchema, null, 1);
fs.writeFileSync(schemaPath, plotSchemaStr);
var plotSchema = Plotly.PlotSchema.get();
var plotSchemaStr = JSON.stringify(plotSchema, null, 1);
fs.writeFileSync(schemaPath, plotSchemaStr);

console.log('ok ' + path.basename(schemaPath));
};
console.log('ok ' + path.basename(schemaPath));
};