Sort object key values in schema#5813
Merged
Merged
Conversation
Contributor
Author
|
Awaiting review. |
alexcjohnson
approved these changes
Jul 17, 2021
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 LGTM!
I noticed one Object.keys that survived unsorted is the svg marker.symbol list:
plotly.js/src/components/drawing/index.js
Line 210 in 03917c6
That's good, because these symbols are in the order of their numeric codes, it would be weird to sort them alphabetically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #5801 (comment)
@plotly/plotly_js