Add willReadFrequently to 2d canvas contexts, where appropriate.#6084
Merged
archmoj merged 4 commits intoplotly:masterfrom Mar 24, 2022
junov:add_willReadFrequently
Merged
Add willReadFrequently to 2d canvas contexts, where appropriate.#6084archmoj merged 4 commits intoplotly:masterfrom junov:add_willReadFrequently
archmoj merged 4 commits intoplotly:masterfrom
junov:add_willReadFrequently
Conversation
This chang add the willReadFrequently:true 2d context creation attribute to call sites where canvases will be read from (i.e getImagData or toDataURL). This is a performance hint that tells the browser to optimize for readbacks. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently The new API will soon be launched in chromium-based web browsers. The objective of this change is to optimize performance and prevent possible performance regressions when this new feature is launched by major web browser in the near future.
archmoj
reviewed
Mar 23, 2022
archmoj
reviewed
Mar 23, 2022
Contributor
|
Thanks very much for the PR! |
|
Hi. I'm still getting browser warning about missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the willReadFrequently:true 2d context creation
attribute to call sites where canvases will be read from (i.e
getImageData or toDataURL). This is a performance hint that tells
the browser to optimize for readbacks.
See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently
The new API will soon be launched in chromium-based web browsers.
The objective of this change is to optimize performance and prevent
possible performance regressions when this new feature is launched
by major web browser in the near future.