Add shadow, lineposition and textcase options to SVG fonts#6983
Merged
Add shadow, lineposition and textcase options to SVG fonts#6983
shadow, lineposition and textcase options to SVG fonts#6983Conversation
Contributor
Author
|
This PR is ready for review 🙏 |
archmoj
changed the title
shadow, decorline and capitalize options to SVG fontsshadow, decorline and textcase options to SVG fonts
emilykl
approved these changes
May 14, 2024
Contributor
Author
|
Thanks very much @emilykl for the review and I am also happy with the results at this point. I would like to have additional approvals before merging. Thank you! |
gvwilson
reviewed
May 15, 2024
Contributor
gvwilson
left a comment
gvwilson
left a comment
There was a problem hiding this comment.
I left a few small comments on the first few files, but I'm nowhere near understanding this code base well enough to say anything substantial. It looks like an extraordinary amount of work - thank you for wading through it.
…g-capitalize - Resolved sonflicts in test/image/baselines/trace_metatext.png
archmoj
changed the title
shadow, decorline and textcase options to SVG fontsshadow, lineposition and textcase options to SVG fonts
alexcjohnson
approved these changes
May 16, 2024
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Looks great, this will make a really nice addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6974 also helps address #4674.
Support additional text font styling options based on
text-shadow,text-decoration-line&text-transform.Please see
src/plots/font_attributes.jsfor these new optoins.@plotly/plotly_js
cc: @ndrezn