Skip to content

Conversation

@birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 17, 2024

closes #7103

This adds support for biome, to make something like the "lint" command below work which just runs the whole repo "biome lint". The work left to do is figure out the syntax for making the other entries in this list work as expected:

"lint": "eslint --version && eslint .",
"lint-fix": "eslint . --fix || true",
"no-new-func": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-new-func: warn}' $(find dist -type f -iname '*.js')",
"no-bad-char": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-misleading-character-class: error}' $(find dist -type f -iname '*.js' | grep plotly)",
"no-dup-keys": "eslint --no-ignore --no-eslintrc --no-inline-config --rule '{no-dupe-keys: error}' $(find dist -type f -iname '*.js' | grep plotly)",
"no-es6-dist": "node tasks/no_es6_dist.js",

@archmoj archmoj marked this pull request as ready for review August 17, 2024 20:26
@archmoj
Copy link
Contributor

archmoj commented Aug 17, 2024

This is great.
Thanks for the PR.
I would open a follow up PR.
💃

@camdecoster
Copy link
Contributor

I'm sorry to necropost to a closed issue, but I'm looking for clarification on the intent of switching to Biome. Linting is set up and working well, but Biome can also format the code (similar to Prettier). I have format-on-save enabled by default in VS Code and it was using the Biome formatting rules to change the files I was saving quite a bit. Should Biome be updating the code per the formatting rules? lint-fix calls the Biome formatting command on the CLI, but that only updates the test mocks. I'd appreciate any clarification you can give.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade from ESLint to Biome - it's 44x faster in this repo

3 participants