Conversation
camdecoster
left a comment
camdecoster
left a comment
There was a problem hiding this comment.
I made a few comments about how to proceed. Unfortunately, a lot of these typos are from dependencies and won't be able to be fixed inside plotly.js.
There was a problem hiding this comment.
This change likely altered the result of some test images, which makes sense. You can download the new images from the Artifacts tab in the CircleCI results and save those into the test images folder and commit them.
There was a problem hiding this comment.
download the new images from the Artifacts tab in the CircleCI results
I'm unclear on how to do that.
test images folder
I'm unclear on the precise location of the "test images" folder.
There was a problem hiding this comment.
I'll take care of it. It can be confusing if you're unfamiliar with the testing system.
There was a problem hiding this comment.
Could you allow edits to the PR by maintainers?
There was a problem hiding this comment.
Allow edits from maintainers
I don't see that text and documentation on that invariably refer to a fork's user created branch.
There was a problem hiding this comment.
It should show up on the PR as described here. If you aren't able to do that, I'll just create my own PR that incorporates your changes.
There was a problem hiding this comment.
aren't able to do that
"you can modify an existing pull request to let repository maintainers make commits to your branch"
I used the master branch for this pull, maybe that's why the Allow edits... text doesn't appear.
I'll just create my own PR that incorporates your changes.
That seems to be the solution to this circumstance.
|
virtual-webgl-jasmine - Failed Cannot start Chrome |
gvwilson
added
community
3 participants
Closes #7531
using
masterfor this pull