build: Add build step before generating the schema#7589
Conversation
| logLevel: 'info' | ||
| }; | ||
|
|
||
| const devtoolsConfig = { |
There was a problem hiding this comment.
@camdecoster Could you add a comment above each of these configs explaining what it's used for (to the extent that you know)?
There was a problem hiding this comment.
I'll come up with something, but the variable names were my attempt at a description.
devtools/test_dashboard/build.mjs
Outdated
There was a problem hiding this comment.
@camdecoster After the cleanup you've done, does this step really need a separate file? Couldn't you just now add build(localDevConfig); to the beginning of the makeSchema() function in schema.mjs?
There was a problem hiding this comment.
That's a fair question. I envisioned this script as being one that could be called elsewhere, but that seems like it violates the YAGNI principle. I'll do as you suggest. We can always add it back.
|
@camdecoster Not a big deal but looks like this results in an extra |
@emilykl this shouldn't cause issues because it's building the library in two different locations: dist and build. The one in build is what's used to generate the schema. It's a little extra overhead, but now we don't have to worry about the schema getting out of sync with the library. |
Description
Add build step before generating the schema.
Closes #7538.
Changes
npm run schemaTesting
npm run schemanpm run schemaNotes
npm startbuilds the library every time a change is made