Skip to content

Fixup cartesian dragbox module#878

Merged
etpinard merged 1 commit into
masterfrom
fixup-registry
Aug 24, 2016
Merged

Fixup cartesian dragbox module#878
etpinard merged 1 commit into
masterfrom
fixup-registry

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

I forget about that module during PRs #833 and #845

cc @rreusser

- use 'drawOne' mehtod instead of 'draw' as per PR #833
- use Registry instead of Plotly[module] as per PR #845
@etpinard etpinard mentioned this pull request Aug 24, 2016
14 tasks
@rreusser

Copy link
Copy Markdown
Contributor

Ah, the .drawOne issue? Do you want to fix it up since you know this better, then I'll mirror the changes to axis transitions?

@etpinard

Copy link
Copy Markdown
Contributor Author

Do you want to fix it up since you know this better,

It is fixed here (unless I'm going bling).

@rreusser

Copy link
Copy Markdown
Contributor

Ohhh, this is a PR, not an issue. Yeah. got it.

@etpinard

Copy link
Copy Markdown
Contributor Author

Haha. Ok I'm merging this so that you can mirror it in your animation PR.

@etpinard
etpinard merged commit 0daa5d6 into master Aug 24, 2016
@etpinard
etpinard deleted the fixup-registry branch August 24, 2016 17:32
rreusser added a commit that referenced this pull request Aug 25, 2016
rreusser added a commit that referenced this pull request Sep 2, 2016
rreusser added a commit that referenced this pull request Sep 6, 2016
rreusser added a commit that referenced this pull request Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants