Skip to content

Add configkeys to offline matching plotly js 1.39.2#1056

Merged
jonmmease merged 2 commits into
plotly:masterfrom
twoporeguys:fix/add-missing-offline-config-keys
Jul 19, 2018
Merged

Add configkeys to offline matching plotly js 1.39.2#1056
jonmmease merged 2 commits into
plotly:masterfrom
twoporeguys:fix/add-missing-offline-config-keys

Conversation

@jeffreypriebe

Copy link
Copy Markdown
Contributor

Looking at plotly js, there are a number of configkeys that are valid that aren't in this offline whitelist. This adds all configkeys from current plotly js.

Note, this PR encompasses: #1042

@jonmmease jonmmease added this to the v3.1.0 milestone Jul 17, 2018
@jonmmease

Copy link
Copy Markdown
Contributor

Thanks @jeffreypriebe , I'll take a look over this when we upgrade to Plotly.js 1.39.x (which will become plotly.js 3.1.0)

@jeffreypriebe

Copy link
Copy Markdown
Contributor Author

Sounds good @jonmmease

Right now, can't output certain valid js configs from python, so running on a fork.

@jonmmease jonmmease changed the title Add configkeys to offline matching plotly js 1.39.1 Add configkeys to offline matching plotly js 1.39.2 Jul 19, 2018
@jonmmease
jonmmease merged commit 9789ab0 into plotly:master Jul 19, 2018
@jonmmease

Copy link
Copy Markdown
Contributor

Thanks @jeffreypriebe!
Eventually we should also work through which of these options should be exposed to the new FigureWidget class.

@jeffreypriebe

Copy link
Copy Markdown
Contributor Author

Great!

Tagging @alextpg in case he wants these changes for future use (3.0 branch).

@alextpg

alextpg commented Jul 20, 2018

Copy link
Copy Markdown

Yup, good. Will be useful in the 3.0. Thanks @jeffreypriebe and @jonmmease!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants