Merged
Conversation
Contributor
|
thank you very much @antoinerg for fixing all this! If we can keep the standard err as it was before by checking for an environment variable I think it would be better. The CI failure has nothing to do with your PR and will not block merging. |
antoinerg
force-pushed
the
bump-orca-1.3.0
branch
from
44637f5 to
313ee4d
Compare
Contributor
Author
|
I forced push to get rid of all the unnecessary cruft. This PR is now considerably simpler following a fix upstream to Orca (plotly/orca#301) and the release of Orca v1.3.1. This is now ready for a review 😸 |
Contributor
|
LGTM! 💃 Thanks @antoinerg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #2301 by: