fix(io): force UTF-8 for write_json/read_json file I/O#5671
Open
Solaris-star wants to merge 1 commit into
Open
fix(io): force UTF-8 for write_json/read_json file I/O#5671Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
Path.write_text/read_text without encoding use the locale default, which on Windows is often cp1252 and raises UnicodeEncodeError/UnicodeDecodeError for non-ASCII figure text. Always pass encoding="utf-8" so JSON round-trips match Linux/macOS. Fixes plotly#5665 Signed-off-by: Solaris-star <820622658@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pio.write_json/pio.read_jsonusePath.write_text/Path.read_textwithout an encoding. On Windows the default is often cp1252, so non-ASCII figure text (e.g.μ 中文) raisesUnicodeEncodeErroron write or mangles/fails on read. macOS/Linux work only because their default is already UTF-8.Fix
Always pass
encoding="utf-8"for both write and read path I/O.Test
Linked Issue
Closes #5665