Load graph reference from pkg copy of plot schema#614
Closed
etpinard wants to merge 1 commit into
Closed
Conversation
- instead of making a request to plot.ly to grab the most up-to-date schema
Contributor
Author
PROS
CONS
I personally think the item under CONS isn't a big deal because:
|
Contributor
Author
Merged
Contributor
|
@etpinard I'm shifting things around wrt our api for a large-ish release. I like the idea of no longer auto-downloading the plot-schema. We have a very simple way to update the plot schema and can just do that with minor version bumps if desired. @chriddyp and @Kully, ya'll OK with stopping the auto-download of |
This was referenced Dec 29, 2016
Closed
Member
|
I'm OK with it! |
Merged
Contributor
|
The ideas from this have been implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #613