Skip to content

add doughnut to api.js to mirror substrate 2.0 changes#24

Open
leoliu-centrality wants to merge 1 commit into
masterfrom
issue-23/doughnut-support-2.0
Open

add doughnut to api.js to mirror substrate 2.0 changes#24
leoliu-centrality wants to merge 1 commit into
masterfrom
issue-23/doughnut-support-2.0

Conversation

@leoliu-centrality
Copy link
Copy Markdown

@leoliu-centrality leoliu-centrality commented Oct 23, 2019 •
edited by jordy25519
Loading

closes #23

cowboy-bebug
cowboy-bebug reviewed Oct 24, 2019
View reviewed changes
Comment thread packages/rpc-core/src/jsonrpc.types.ts
state: {
call(method: Text | string, data: Bytes | Uint8Array | string, block?: Hash | Uint8Array | string): Observable<Bytes>;
getChildKeys(childStorageKey: any, prefix: any, block?: Hash | Uint8Array | string): Observable<Vec<StorageKey>>;
getChildKeys(childStorageKey: any, key: any, block?: Hash | Uint8Array | string): Observable<Vec<StorageKey>>;
Copy link
Copy Markdown

@cowboy-bebug cowboy-bebug Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cowboy-bebug
cowboy-bebug reviewed Oct 24, 2019
View reviewed changes
Comment thread packages/rpc-core/src/jsonrpc.types.ts
getChildStorageHash(childStorageKey: any, key: any, block?: Hash | Uint8Array | string): Observable<Hash>;
getChildStorageSize(childStorageKey: any, key: any, block?: Hash | Uint8Array | string): Observable<u64>;
getKeys(prefix: any, block?: Hash | Uint8Array | string): Observable<Vec<StorageKey>>;
getKeys(key: any, block?: Hash | Uint8Array | string): Observable<Vec<StorageKey>>;
Copy link
Copy Markdown

@cowboy-bebug cowboy-bebug Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jordy25519 jordy25519 marked this pull request as ready for review October 24, 2019 23:57
@jordy25519 jordy25519 requested a review from ianhe8x October 24, 2019 23:57
@jordy25519
Copy link
Copy Markdown

jordy25519 commented Oct 24, 2019

@ianhe8x please advise about the travisci errors

ianhe8x
ianhe8x suggested changes Oct 25, 2019
View reviewed changes
Comment thread packages/types/src/primitive/Extrinsic/SignerPayload.ts
// We can ignore the properties, added via Struct.with
const _Payload: Constructor<SignerPayloadType> = Struct.with({
address: 'Address',
doughnut: Option.with(Doughnut),
Copy link
Copy Markdown

@ianhe8x ianhe8x Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you use 'Option<Doughnut>' which will allow user replace the default implementation

@ianhe8x
Copy link
Copy Markdown

ianhe8x commented Oct 25, 2019

I don't see doughnut is included anywhere in Extrinsic, the changes are all about having doughnut in signature.
BTW, the tests are old, they might work once in cennznet/api, but i think they don't work in this branch. (you don't even have tx.addDougnhut() in this branch)

@ianhe8x
Copy link
Copy Markdown

ianhe8x commented Oct 25, 2019

I also suggest not changing the default extrinsic implementation, which might make rebasing polkadotjs too much difficult. you can make a doughnut-type package or a doughnut folder in types to contain the modified version of extrinsic related classes, and change packages/types/src/interfaces/runtime/types.ts to make your extrinsic implementation become default.

@ianhe8x
Copy link
Copy Markdown

ianhe8x commented Oct 25, 2019

I'm not sure what happens to the ci, need more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cowboy-bebug cowboy-bebug cowboy-bebug left review comments

@ianhe8x ianhe8x ianhe8x requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doughnut 2.0 Support

4 participants

@leoliu-centrality @jordy25519 @ianhe8x @cowboy-bebug