Skip to content

Option to display values below QRcode (Fix #4)#17

Closed
mathieumd wants to merge 4 commits into
pluginsGLPI:developfrom
mathieumd:master
Closed

Option to display values below QRcode (Fix #4)#17
mathieumd wants to merge 4 commits into
pluginsGLPI:developfrom
mathieumd:master

Conversation

@mathieumd
Copy link
Copy Markdown

Massively based on the work of tcse10 in the forum.

@trasher trasher requested a review from ddurieux April 12, 2018 06:15
@trasher
Copy link
Copy Markdown
Contributor

trasher commented Apr 12, 2018

I'm not developer on the current plugin but:

  • you have CS issues to fix (see travs build details)
  • as far as I've seen, you update the SQL schema, but you did not handle the upgrad part.

@mathieumd
Copy link
Copy Markdown
Author

Thanks for your comment @trasher. Could you look at the migration code please; I'm not confident at all on how to achieve that...

@trasher
Copy link
Copy Markdown
Contributor

trasher commented Jun 17, 2018

Hi @mathieumd ; your migration code seems correct; executeMigration should probably not be called where you did; but as I've said, I'm not developper on the plugin, dunno how this is handled. Ping @ddurieux

@cedric-anne cedric-anne changed the base branch from master to develop July 6, 2018 08:18
@cedric-anne
Copy link
Copy Markdown
Contributor

Ping @ddurieux

@xacobofg xacobofg mentioned this pull request Nov 29, 2018
@informaticavera
Copy link
Copy Markdown

hello, first of all I apologize for my english, I'm using the google translator.

we have uploaded all your modifications to the glpi plugin but we see an error that we do not know how to solve:

PHP Fatal error: Cannot declare class Cezpdf, because the name is already in use in /usr/share/glpi/plugins/barcode/lib/ezpdf/class.ezpdf.php on line 0, referer: http://....../glpi/front/computer.php

We would be very grateful if you can help us

@ddurieux
Copy link
Copy Markdown
Collaborator

Merged manually

@ddurieux ddurieux closed this Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants