Remove calling to a parent that does not exists#57
Merged
cedric-anne merged 1 commit intoNov 12, 2019
Merged
Conversation
trasher
requested changes
Nov 8, 2019
Contributor
Author
These methods are declared in CommonDBTM, not in CommonGLPI, and these classes are not related to any DB item. |
trasher
approved these changes
Nov 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 7.4, following deprecation message is triggered when trying to use plugin massive actions:
PHP Deprecated function: Cannot use "parent" when current class scope has no parent in /var/www/glpi/plugins/barcode/inc/qrcode.class.php at line 332 PHP Deprecated function: Cannot use "parent" when current class scope has no parent in /var/www/glpi/plugins/barcode/inc/qrcode.class.php at line 353 PHP Deprecated function: Cannot use "parent" when current class scope has no parent in /var/www/glpi/plugins/barcode/inc/qrcode.class.php at line 418Indeed,
PluginBarcodeBarcodeandPluginBarcodeQRcodehave no parent class.