-
Notifications
You must be signed in to change notification settings - Fork 2
Fix headers, add units tests and Pull Request template #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rom1-B
reviewed
Sep 15, 2025
Rom1-B
reviewed
Sep 15, 2025
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Rom1-B
requested changes
Sep 15, 2025
Contributor
Rom1-B
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tests" is missing from the phpstan.neon paths.
Rom1-B
requested changes
Sep 15, 2025
Contributor
Rom1-B
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tests" is missing from the phpstan.neon paths.
Rom1-B
approved these changes
Sep 16, 2025
Rom1-B
requested changes
Sep 18, 2025
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Rom1-B
approved these changes
Sep 23, 2025
Lainow
added a commit
that referenced
this pull request
Oct 13, 2025
* Fix header * Add units tests and PR template * Update tests/units/ConfigTest.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> * Fix comments * Fix units tests * Fix units tests * Fix phpstan * Fix phpstan * Fix phpstan and gitignore * Fix phpstan * Fix phpstan * Fix phpstan * Fix phpstan * Remove tests files * Assign item group to technician group * Add mandatory field to change and problem * Add index * Fix units tests * Implement suggestions * Implement suggestions * Update src/Controller.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> * Implement assign technical group ans manager when category changed * Fix phpstan --------- Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Lainow
added a commit
that referenced
this pull request
Nov 13, 2025
* Add README and CHANGELOG * Update Readme * Fix headers, add units tests and Pull Request template (#1) * Fix header * Add units tests and PR template * Update tests/units/ConfigTest.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> * Fix comments * Fix units tests * Fix units tests * Fix phpstan * Fix phpstan * Fix phpstan and gitignore * Fix phpstan * Fix phpstan * Fix phpstan * Fix phpstan * Remove tests files * Assign item group to technician group * Add mandatory field to change and problem * Add index * Fix units tests * Implement suggestions * Implement suggestions * Update src/Controller.php Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> * Implement assign technical group ans manager when category changed * Fix phpstan --------- Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com> * FIx lint --------- Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix headers, add units tests and Pull Request template