Fix: reduce MSSQL connections per collect; add unit tests#176
Draft
Rom1-B wants to merge 2 commits into
Draft
Conversation
Contributor
|
@Rom1-B Tell me when I can test it in my environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Each collect run was opening up to N*8 MSSQL connections (one per
get*()method per device).A single
PluginSccmSccmdbis now created once per config inexecuteCollect()and passed to all per-device data fetching methods, reducing connections to 2 per config regardless of device count.The
set*()methods inPluginSccmSccmxmlaccept an optional?PluginSccmSccmparameter for dependency injection, enabling a PHPUnit test suite covering query building, XML generation, and data transformation logic (47 tests, 209 assertions).