feat: revamp socket URL handling with currentScript source#133
Merged
Conversation
Closed
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #105. It partially reverts changes in #106 because I was wrong about some assumptions on Webpack's
__resourceQuery.This change keeps IE11 compatibility for everyone other than WDS users (This is because, even if they polyfill URL, we will always run before the polyfill - unconfirmed though). All code with usage of the
URLconstructor is self-contained withinWDSSocket.Edit:
I've pulled the trigger to expand the scope of this.
Additional features resolves:
Fixes #30
Fixes #100