Skip to content

resolve webpack-hot-middleware conflicts #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xughv wants to merge 4 commits into from
Closed

resolve webpack-hot-middleware conflicts #49

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0477628
chore(examples): update dependencies
xughv Mar 19, 2020
081cce6
fix: resolve webpack-hot-middleware conflicts
xughv Mar 19, 2020
34a1367
fix: avoid the effects of path segment separator
xughv Mar 20, 2020
f9a5b04
Merge remote-tracking branch 'pmmmwh/master'
xughv Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/runtime/WHMEventSource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
/*
* If the consumers setup is to use webpack-hot-middleware with a custom express server
* we want to bind onto the EventSource for error tracking
*
* [Ref](https://github.com/webpack-contrib/webpack-hot-middleware/blob/cb29abb9dde435a1ac8e9b19f82d7d36b1093198/client.js#L152)
*/

const singletonKey = '__webpack_hot_middleware_reporter__';

module.exports = function loadWHMEventSource(messageHandler) {
const client = require('webpack-hot-middleware/client');
const client = window[singletonKey] || require('webpack-hot-middleware/client');

client.useCustomOverlay({
showProblems(type, data) {
Expand Down