Created AsciiEffect (to improve), Ascii Content Page and Ascii Demo (to fix)#684
Created AsciiEffect (to improve), Ascii Content Page and Ascii Demo (to fix)#684vanruesc merged 2 commits intopmndrs:devfrom LucaArgentieri:main
Conversation
|
Thanks! I'll take it from here. |
|
If you have contribution guidelines I can try to improve the code and make it consistent with the library. I can also try to understand how the other effects are managed, I will try to contribute as I can |
|
The contribution guide can be found here. There's not much that needs to be changed here apart from some linting and refactoring. I'm short on time and it's faster for me to do the clean up myself, but thanks for offering help. Also, optimizing the shader requires active debugging which isn't really doable through PR comments. You can check out the concepts in v7 through the existing effects and then try your hand at porting this effect to v7 once I'm done with the refactoring. I'll create a new ticket for that task. |
|
→#685 |
Related issue: #683
Description
Created: