Update runtime weights for 1.2.0#223
Merged
fellowship-merge-bot[bot] merged 9 commits intopolkadot-fellows:mainfrom Mar 19, 2024
Merged
Update runtime weights for 1.2.0#223fellowship-merge-bot[bot] merged 9 commits intopolkadot-fellows:mainfrom
fellowship-merge-bot[bot] merged 9 commits intopolkadot-fellows:mainfrom
Conversation
Member
|
Btw |
fellowship-merge-bot bot
added a commit
that referenced
this pull request
Mar 12, 2024
Relates to: #223 A type alias `type Nis = pallet_balances::Pallet::<Runtime, NisCounterpartInstance>;` for the second `pallet_balances` instance was introduced [here](#58). Unfortunately, nobody (including myself) realized that `Nis` is also used for `[pallet_nis, Nis]`. As a result, the benchmark for `pallet_nis` runs as if it were for `pallet_balances`, and the result can be seen here: [link](3bb9a02#diff-9bfa230a9b7f40866df3f84e81dfea72a64cc31bd9ef6e594c3d43582ba76522). Therefore, this PR fixes this anomaly. <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [x] Does not require a CHANGELOG entry --------- Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
This was referenced Mar 12, 2024
Merged
eskimor
approved these changes
Mar 15, 2024
…porMessage` handlers: https://github.com/polkadot-fellows/runtimes/pull/159/files#diff-d2ccb0e6ba82a0a63933d17d80d3ecc3a6043d041edd954791076d871fb395acR279-R280 https://github.com/polkadot-fellows/runtimes/pull/223/files#diff-9462f9c932d2d39defa28ae668aea685d928545f874f93c45c550382eb350525R357-R358
Contributor
Author
Contributor
Author
|
/merge |
Contributor
|
Enabled Available commands
For more information see the documentation |
Contributor
|
L.E.: patch fix removes extra/wrong extrinsinc weight being added on top of benchmarked weight, so in the end we have larger benchmarked weight (which is correct following benchmarking accuracy improvements), but overall lower extrinsic fees 👍 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #140
Chain-specs generated from the commit:
f5aeb7e8cc024a17a42ca547645f25f2ae28e4f4.Polkadot binary used:
TODO
pallet_xcm_benchmarks_fungible.rsto diffs - Missing other benchmarks fromweights/xcm/pallet_xcm_benchmarks_fungible.rsggwpez/substrate-weight-compare#60polkadotbinary from "lastest release- v1.8.0 " or "latest compatible bump release - v1.7.2" ?set_candidacy_bondInvestigate too big change for benchmarkset_candidacy_bondfor 1.2.0 release #230teleport/reserver_assets_transfer(they were not regenerated with v1.1.2 + compare with regenerated in polkadot-sdk) Investigate too big change for benchmarkteleport_assets/reserve_transfer_assetsfor 1.2.0 release #231The comparison of this branch with
release-v1.1.2(latest release)Note:
Change [%]has threashold 5, so it show only if change is more than5%or less than-5%.Polkadot weights
Kusama weights
AssetHubPolkadot weights
AssetHubKusama
BridgeHubPolkadot
BridgeHubKusama
Collectives weights
Encointer weights
Glutton Kusama weights