chore: move ethers utils to its own package#35
Closed
cbrzn wants to merge 4 commits into
Closed
Conversation
krisbitney
suggested changes
Mar 3, 2023
Contributor
krisbitney
left a comment
krisbitney
left a comment
There was a problem hiding this comment.
Looks great!
Could you add CI?
| @@ -0,0 +1,15 @@ | |||
| type Module { | |||
| solidityKeccak256Bytes(bytes: String!): String! | |||
Contributor
There was a problem hiding this comment.
This method has bytes in the name but accepts a string argument and returns a string. Maybe adjust the name? Same with other methods
| pub fn get_signer_address(args: wrap::ArgsGetSignerAddress) -> String { | ||
| let address = PolywrapSigner::new(&args.connection).address(); | ||
| format!("{:#x}", address) | ||
| format!("{:#x}", address).to_string().to_lowercase() |
Contributor
There was a problem hiding this comment.
format!("{:#x}", address) already returns a lowercase String
Contributor
Author
|
converting this to draft. this is just for example purposes, and its being used by the safe wrapper. after talking with @krisbitney we're going to take the path of improving the logic in PR #41. once the PR 41 has been completed we can close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR aims to create the
ethers-utilswrapper so it can be used in the safe-wrapperthe long-term of this is to do a cargo workspace with the different ethereum wrappers (core, utils, signer, transaction)