feat(provider): handle local sign support in necessary methods#49
Merged
dOrgJelli merged 3 commits intoMar 15, 2023
Merged
Conversation
cbrzn
force-pushed
the
feat/handle-raw-tx-in-provider
branch
from
ac46de0 to
41f1fd0
Compare
cbrzn
force-pushed
the
feat/handle-raw-tx-in-provider
branch
from
41f1fd0 to
4fdedd8
Compare
cbrzn
changed the title
dOrgJelli
requested changes
Mar 15, 2023
| const signer = await connection.getSigner() | ||
| let signature = ""; | ||
| // This is a hack because in ethers v5.7 this method is experimental | ||
| // when when we update to ethers v6 this wont be needed. More info: |
Contributor
There was a problem hiding this comment.
What's stopping us from updating to v6 now?
Contributor
Author
There was a problem hiding this comment.
nice q... nothing tbh
Contributor
Author
There was a problem hiding this comment.
i think since we're in the hackathon I just don't want to spend time on these things (for the sake of delivering in the hackathon)
dOrgJelli
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR aims to add handle of signing for custom signers