Abort handler implementation and removal of URI from wrapper.invoke#96
Merged
Conversation
… args as part of invocation error (can be done in the client)
…tom abort_handler in build_abort_handler
namesty
approved these changes
May 18, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to decouple abort handling and URI from the wrapper runtime.
The abort handler allows the client to handle the abort logic instead of leaving it to the individual wrapper runtime implementations. This gives more power to the client, it allows it to standardize abort logic across all wrappers and, in the future, it can allow users to customize the abort logic (by providing a custom abort handler).
Other notable changes:
invoke_wrapper_rawmethod).